SPIRV-Cross workarounds for early_fragment_tests#1171
Merged
ben-clayton merged 2 commits intogoogle:masterfrom Oct 9, 2017
Merged
SPIRV-Cross workarounds for early_fragment_tests#1171ben-clayton merged 2 commits intogoogle:masterfrom
ben-clayton merged 2 commits intogoogle:masterfrom
Conversation
Some optimizations require more recent versions of GL that macOS supports. Add an option to remove optimizations that should have no impact on the end result. Also fix a bunch of govet issues in shadertools.go.
dsrbecky
approved these changes
Oct 9, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This isn't supported on macOS, either as core OpenGL (too recent a profile), or as an extension.
Use SPIRV-Cross to remove these optimizations for compat.