GAPID gfxtrace file associations#1276
Conversation
ben-clayton
left a comment
ben-clayton
left a comment
There was a problem hiding this comment.
Approving assuming you've tested windows uninstallation. Thank you
| Target="[!gapid.exe]" WorkingDirectory="APPLICATIONROOTDIRECTORY" Icon="gapid.ico" /> | ||
| <RemoveFolder Id="CleanUpShortCut" Directory="ApplicationProgramsFolder" On="uninstall" /> | ||
| <RegistryValue Root="HKCU" Key="Software\Google\GAPID" Name="installed" Type="integer" Value="1" KeyPath="yes" /> | ||
| <RegistryValue Root="HKCU" Key="SOFTWARE\Google\GAPID" Name="installed" Type="integer" Value="1" KeyPath="yes" /> |
There was a problem hiding this comment.
This is an odd change. Completely from memory, isn't "Software" more common? Again, IIRC, the registry is case insensitive, so may not matter.
There was a problem hiding this comment.
OK, so I changed this to match what I had below and I had it all uppercase below, because the key is actually all upper case in my registry...
However, it appears you are right, convention now is to use "Software", so I've updated it. Yes, the registry keys are case insensitive.
|
|
||
| <Icon Id="gapid.ico" SourceFile="gapid.ico" /> | ||
|
|
||
| <DirectoryRef Id="GAPID"> |
There was a problem hiding this comment.
Does this automatically delete these keys on uninstallation? I vaguely remember there needing to be some additional attribute for telling WiX that these keys are safe to delete on uninstall.
There was a problem hiding this comment.
Yes, I've tested it and the registry values all get cleaned up on uninstall.
This event is sent on OSX if the user requests GAPID to open a gfxtrace file, for example via double-clicking on a gfxtrace file in the Finder. This event is sent if the application is already running, or if it just has been started in response to opening a file.
2 participants
Associate .gfxtrace files with GAPID on all platforms:
Fixes #565