Ensure GLSL variables are initialized#918
Merged
dsrbecky merged 1 commit intogoogle:masterfrom Aug 16, 2017
Merged
Conversation
The compat layer sometimes creates code which uses uninitialized variables. Although the output is technically correct, it makes my driver complain a lot.
ben-clayton
approved these changes
Aug 16, 2017
| // Explicitly initialize locals. This is a work around for SPIR-V cross problem | ||
| // where it may generate code which reads locals before initializing them. | ||
| // For example, "v.x = 42.0;" becomes "v = vec4(42.0, v.y, v.z, v.w);" | ||
| void SpvManager::initLocals() { |
Contributor
There was a problem hiding this comment.
Looks like a good thing to upstream.
Contributor
Author
There was a problem hiding this comment.
Well, the proper fix would be in SPIRV-Cross. I have investigated that approach for a bit, but gave up. I just ended fixing a bug.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The compat layer sometimes creates code which uses uninitialized
variables. Although the output is technically correct, it makes
my driver complain a lot.