Default the 'disable PCS' option to true.#923
Merged
pmuetschard merged 1 commit intogoogle:masterfrom Aug 17, 2017
Merged
Conversation
pmuetschard
changed the title
ben-clayton
reviewed
Aug 16, 2017
|
|
||
| private static boolean getBoolean(Properties properties, String name, boolean dflt) { | ||
| return "true".equalsIgnoreCase(properties.getProperty(name, dflt ? "true" : "false")); | ||
| if (dflt) { |
Contributor
There was a problem hiding this comment.
This implementation is making me go cross eyed trying to figure out the logic. What was wrong with the old implementation?
Member
Author
There was a problem hiding this comment.
It is now consistent (it was slightly inconsistent before):
if dflt is true only a value of "false" will cause the result to be false, similar to how if dflt is false, only "true" will cause the result to be true.
ben-clayton
approved these changes
Aug 17, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.