feat ✨ compute crawler factories #189
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sudiptob2
force-pushed
the
feat/188/compute-crawler-factories
branch
from
1a36273 to
b4922e7
Compare
0xDeva
approved these changes
Jun 9, 2023
sudiptob2
changed the title
0xDeva
reviewed
Jun 12, 2023
| def create_crawler(cls, name): | ||
| """Returns the appropriate crawler.""" | ||
|
|
||
| if name == "compute_instances": |
Collaborator
There was a problem hiding this comment.
What is the order used here in this list? Can you consider sorting it by alphabetic order please?
Contributor
Author
There was a problem hiding this comment.
Sorted according to the classNames.
0xDeva
approved these changes
Jun 12, 2023
sudiptob2
force-pushed
the
feat/188/compute-crawler-factories
branch
from
47e9b8d to
2e850a2
Compare
0xDeva
approved these changes
Jun 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #188