Include Windows in GitHub Actions build #38
Conversation
dcoles
force-pushed
the
windows-build
branch
2 times, most recently
from
7bc5117 to
c64b6fd
Compare
|
Latest build (8034688123) is |
|
Looks good to me, thanks. Would you mind rebasing? |
Unfortunately I can't. Copybarra wiped away the Windows build again: 6965973 |
|
Bummer :/ We're working on it, seems caused by a copybara bug which we are told will be fixed soon. |
-- c64b6fd by David Coles <dcoles@dcoles.net>: Include Windows in GitHub Actions build This also preserves the `gemma` binary as a build artefact should folks want to grab a pre-built binary. Dropped the use of the lukka/cmake actions due to conflicts with `--preset`. This isn't that bad as we were mostly overriding the default behaviour anyway. It also shaves ~2 min off the build since the GitHub builders already have CMake pre-installed. COPYBARA_INTEGRATE_REVIEW=#38 from dcoles:windows-build c64b6fd PiperOrigin-RevId: 610449220
dcoles
force-pushed
the
windows-build
branch
from
c64b6fd to
7aeade5
Compare
|
Our Copybara automation has effectively merged this pull request and imported it as a commit in Unfortunately, the automation doesn't actually merge pull requests right now, so we have to manually close it – we're looking into fixing this asap. Thanks for your contribution! |
|
Hi @dan-zheng,
No worries. I know how much a pain syncing internal/external repositories can be.
I rebased my branch onto the current |
3 participants
This also preserves the
gemmabinary as a build artefact should folks want to grab a pre-built binary.Dropped the use of the lukka/cmake actions due to conflicts with
--preset. This isn't that bad as we were mostly overriding the default behaviour anyway.It also shaves ~2 min off the build since the GitHub builders already have CMake pre-installed.
Important
Currently the resulting Windows binary is being detected as
Trojan:Win32/Phonzy.B!mlby Windows Defender ...and only Windows Defender. This is almost certainly a false positive given that the binary is built on GitHub's official "windows_latest" image with the provided CMake and Clang compilers. I've submitted the file to Microsoft Security Intelligence (Submission ID:f2092a44-4b58-45bb-b6ed-071d43a9bc2a) to ask that they investigate.Also opened actions/runner-images#9403 to report the issue.