protoc-gen-openapi,protoc-gen-jsonschema: strip multiline linter comments#474
Open
alliasgher wants to merge 1 commit intogoogle:mainfrom
Open
protoc-gen-openapi,protoc-gen-jsonschema: strip multiline linter comments#474alliasgher wants to merge 1 commit intogoogle:mainfrom
alliasgher wants to merge 1 commit intogoogle:mainfrom
Conversation
…ents The regex `\(-- .* --\)` used to remove proto linter comments (delimited by `(--` and `--)`) did not match comments that span multiple lines because `.` does not match newlines by default. Multiline comments required by AIP-200 were therefore leaked into the generated OpenAPI/JSON Schema output. Add the `(?s)` flag so `.` matches any character including newlines. Fixes google#462 Signed-off-by: alliasgher <alliasgher123@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #462. The regex
\(-- .* --\)used for stripping AIP-200 linter comments didn't match across newlines. Added(?s)flag to both generators so multiline comments like(-- ... --)spanning several lines are correctly removed.