server: Add note about RequestLogger to server.New docs#292
Merged
zombiezen merged 3 commits intogoogle:masterfrom Aug 8, 2018
enocom:server-docs
Merged
server: Add note about RequestLogger to server.New docs#292zombiezen merged 3 commits intogoogle:masterfrom enocom:server-docs
zombiezen merged 3 commits intogoogle:masterfrom
enocom:server-docs
Conversation
A RequestLogger does not log HealthChecks. This commit documents that fact. Fixes #155.
enocom
changed the title
zombiezen
reviewed
Aug 7, 2018
server/server.go
Outdated
|
|
||
| // New creates a new server. New(nil) is the same as new(Server). | ||
| // New creates a new server. New(nil) is the same as new(Server). Note: A | ||
| // configured Requestlogger will not log HealthChecks. |
Contributor
There was a problem hiding this comment.
This seems like a more appropriate message under ListenAndServe. WDYT?
Contributor
Author
There was a problem hiding this comment.
Both seem fine to me. I'll update.
Contributor
Author
|
The build failures are a result of |
zombiezen
approved these changes
Aug 8, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A RequestLogger does not log HealthChecks. This commit documents that
fact.
Fixes #155.