CONTRIBUTING: add section about squashing#356
Merged
zombiezen merged 3 commits intogoogle:masterfrom Aug 23, 2018
Merged
Conversation
enocom
approved these changes
Aug 22, 2018
Contributor
enocom
left a comment
enocom
left a comment
There was a problem hiding this comment.
This addition is very helpful. Thank you!
vangent
approved these changes
Aug 22, 2018
ijt
reviewed
Aug 22, 2018
CONTRIBUTING.md
Outdated
| - Ensure that the first line summary starts with the primary package affected, | ||
| followed by a colon, followed by a short summary of the change, like | ||
| "blob/gcsblob: made more blobby (#123)". | ||
| - If the change is addressing an issue, make the commit message ends with a |
ijt
approved these changes
Aug 22, 2018
shantuo
approved these changes
Aug 23, 2018
Contributor
Author
|
Thanks everyone! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please do not merge until everyone has approved.