Added link to documentation#1565
Merged
Merged
Conversation
googlebot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #1565 +/- ##
=======================================
Coverage 67.90% 67.90%
=======================================
Files 95 95
Lines 8722 8722
=======================================
Hits 5923 5923
Misses 1892 1892
Partials 907 907 Continue to review full report at Codecov.
|
gmlewis
requested changes
Jun 21, 2020
| [package docs]: https://godoc.org/github.com/google/go-github/github | ||
| [GraphQL API v4]: https://developer.github.com/v4/ | ||
| [shurcooL/githubv4]: https://github.com/shurcooL/githubv4 | ||
| [documentation]: https://pkg.go.dev/github.com/google/go-github/v32/github?tab=doc |
Collaborator
There was a problem hiding this comment.
Please delete this line and change the URL above on line 225 to this one:
[package docs]: https://pkg.go.dev/github.com/google/go-github/v32/github
Let's also get rid of the "?tab=doc" because that is added by the backend and may change.
Removed redundant link
gmlewis
approved these changes
Jun 21, 2020
Collaborator
gmlewis
left a comment
gmlewis
left a comment
There was a problem hiding this comment.
Thank you, @reetuparna !
LGTM.
Merging.
n1lesh
pushed a commit
to n1lesh/go-github
that referenced
this pull request
Oct 2, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1561