Skip to content

Conversation

@elminster-aom
Copy link
Contributor

@elminster-aom elminster-aom commented Nov 7, 2025

BREAKING CHANGE: SCIMService.ListSCIMProvisionedGroupsForEnterprise is now EnterpriseService.ListProvisionedSCIMEnterpriseGroups.

Fixes: #3813

Summary

From API Docs https://docs.github.com/en/enterprise-cloud@latest/rest/enterprise-admin/scim, implement:

  • GET /scim/v2/enterprises/{enterprise}/Groups

Breaking Change

The SCIMService.ListSCIMProvisionedGroupsForEnterprise method has been moved to EnterpriseService.ListProvisionedSCIMGroups.

@elminster-aom elminster-aom changed the title Implement Enterprise SCIM Implement Enterprise SCIM - EnterpriseService.ListProvisionedSCIMGroupsForEnterprise Nov 10, 2025
@codecov
Copy link

codecov bot commented Nov 11, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.38%. Comparing base (d69610a) to head (7368118).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3814   +/-   ##
=======================================
  Coverage   92.38%   92.38%           
=======================================
  Files         195      196    +1     
  Lines       14094    14094           
=======================================
  Hits        13021    13021           
  Misses        884      884           
  Partials      189      189           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@elminster-aom elminster-aom marked this pull request as ready for review November 12, 2025 16:58
@elminster-aom elminster-aom mentioned this pull request Nov 12, 2025
12 tasks
@gmlewis gmlewis added NeedsReview PR is awaiting a review before merging. Breaking API Change PR will require a bump to the major version num in next release. Look here to see the change(s). labels Nov 12, 2025
Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @elminster-aom!
Did we agree in another PR not to have methods end with the suffix ...ForEnterprise?

@elminster-aom
Copy link
Contributor Author

Did we agree in another PR not to have methods end with the suffix ...ForEnterprise?

@gmlewis, I couldn't find the PR you mention but I think the word "Enterprise" should appear somehow (Maybe with just an "E"? Suggestions are welcome) otherwise it may get confusing with the other SCIM resources in /github/scim.go.

@elminster-aom elminster-aom changed the title Implement Enterprise SCIM - EnterpriseService.ListProvisionedSCIMGroupsForEnterprise Implement Enterprise SCIM - EnterpriseService.ListProvisionedSCIMEnterpriseGroups Nov 13, 2025
@gmlewis
Copy link
Collaborator

gmlewis commented Nov 13, 2025

Did we agree in another PR not to have methods end with the suffix ...ForEnterprise?

@gmlewis, I couldn't find the PR you mention but I think the word "Enterprise" should appear somehow (Maybe with just an "E"? Suggestions are welcome) otherwise it may get confusing with the other SCIM resources in /github/scim.go.

The idea is that for all our methods, the service must first be specified, like enterpriseService.MethodToCall so we shouldn't need to repeat the ForEnterprise part.

@gmlewis gmlewis changed the title Implement Enterprise SCIM - EnterpriseService.ListProvisionedSCIMEnterpriseGroups feat!: Implement Enterprise SCIM - EnterpriseService.ListProvisionedSCIMEnterpriseGroups Nov 13, 2025
Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @elminster-aom!
LGTM
Awaiting second LGTM+Approval before merging.

cc: @alexandear

@elminster-aom elminster-aom changed the title feat!: Implement Enterprise SCIM - EnterpriseService.ListProvisionedSCIMEnterpriseGroups feat!: Implement Enterprise SCIM - EnterpriseService.ListProvisionedSCIMGroups Nov 13, 2025
@gmlewis gmlewis removed the NeedsReview PR is awaiting a review before merging. label Nov 14, 2025
@gmlewis
Copy link
Collaborator

gmlewis commented Nov 14, 2025

Thank you, @elminster-aom and @alexandear!
Merging.

@gmlewis gmlewis merged commit e53f61e into google:master Nov 14, 2025
7 checks passed
@elminster-aom elminster-aom deleted the enterpriseSCIM branch November 17, 2025 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Breaking API Change PR will require a bump to the major version num in next release. Look here to see the change(s).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement Enterprise SCIM

5 participants