-
Notifications
You must be signed in to change notification settings - Fork 2.2k
feat!: Implement Enterprise SCIM - EnterpriseService.ListProvisionedSCIMGroups #3814
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3814 +/- ##
=======================================
Coverage 92.38% 92.38%
=======================================
Files 195 196 +1
Lines 14094 14094
=======================================
Hits 13021 13021
Misses 884 884
Partials 189 189 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
gmlewis
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @elminster-aom!
Did we agree in another PR not to have methods end with the suffix ...ForEnterprise?
@gmlewis, I couldn't find the PR you mention but I think the word "Enterprise" should appear somehow (Maybe with just an "E"? Suggestions are welcome) otherwise it may get confusing with the other SCIM resources in /github/scim.go. |
The idea is that for all our methods, the service must first be specified, like |
gmlewis
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @elminster-aom!
LGTM
Awaiting second LGTM+Approval before merging.
cc: @alexandear
Co-authored-by: Oleksandr Redko <oleksandr.red+github@gmail.com>
|
Thank you, @elminster-aom and @alexandear! |
BREAKING CHANGE:
SCIMService.ListSCIMProvisionedGroupsForEnterpriseis nowEnterpriseService.ListProvisionedSCIMEnterpriseGroups.Fixes: #3813
Summary
From API Docs https://docs.github.com/en/enterprise-cloud@latest/rest/enterprise-admin/scim, implement:
/scim/v2/enterprises/{enterprise}/GroupsBreaking Change
The
SCIMService.ListSCIMProvisionedGroupsForEnterprisemethod has been moved toEnterpriseService.ListProvisionedSCIMGroups.