-
Notifications
You must be signed in to change notification settings - Fork 2.2k
fix!: Fix field selection and bugs in ProjectsV2 GET endpoints #3809
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
fix!: Fix field selection and bugs in ProjectsV2 GET endpoints #3809
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3809 +/- ##
=======================================
Coverage 92.27% 92.28%
=======================================
Files 192 192
Lines 13896 13902 +6
=======================================
+ Hits 12823 12829 +6
Misses 884 884
Partials 189 189 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
gmlewis
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @stephenotalora!
Please add testBadOptions to all your new unit tests to improve the code coverage.
…t-and-patch-project-item-fix
Good catch, @gmlewis 🙇🏼 fixed! I was deep in the bug fixes and glossed over that. 👍 |
gmlewis
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @stephenotalora!
LGTM.
Awaiting second LGTM+Approval from any other contributor to this repo before merging.
cc: @stevehipwell - @alexandear - @zyfy29
| // It contains the field ID and the new value to set. | ||
| // | ||
| // GitHub API docs: https://docs.github.com/rest/projects/items#update-project-item-for-organization | ||
| type ProjectV2FieldUpdate struct { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not?
| type ProjectV2FieldUpdate struct { | |
| type UpdateProjectV2Field struct { |
BREAKING CHANGE:
UpdateProjectItemOptions.Fieldis now[]*ProjectV2FieldUpdate.Discovered these issues while integrating the related project item APIs exposed in
V77.Fixes bugs in the implementation of support for field selection and updates in the following project item endpoints:
GetOrganizationProjectItemandGetUserProjectItem.UpdateOrganizationProjectItemandUpdateUserProjectItem.Adds or updates tests to verify correct handling of these cases.
Covers:
https://docs.github.com/en/rest/projects/items?apiVersion=2022-11-28
Related REST API docs:
Complements: #3793