-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Support expand Deployment Statuses API #1036
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
|
|
I signed it! |
|
CLAs look good, thanks! |
gmlewis
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @unblee!
LGTM.
Awaiting second LGTM before merging.
gauntface
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM from me too and thank you for the discussion in the original issue to claim this work before getting started 🥇
|
Thank you, @gauntface. |
|
Thank you, @urohit011 @gmlewis @gauntface 😄 |
Fixes #1035
Changes:
application/vnd.github.flash-preview+json)environmentparameter toDeploymentStatusRequeststruct