Skip to content

Conversation

@unblee
Copy link
Contributor

@unblee unblee commented Oct 25, 2018

Fixes #1035

Changes:

  • Add custom media type(application/vnd.github.flash-preview+json)
  • Add environment parameter to DeploymentStatusRequest struct

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@unblee
Copy link
Contributor Author

unblee commented Oct 25, 2018

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@googlebot googlebot added cla: yes Indication that the PR author has signed a Google Contributor License Agreement. and removed cla: no labels Oct 25, 2018
Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @unblee!
LGTM.
Awaiting second LGTM before merging.

@gmlewis gmlewis requested a review from gauntface October 30, 2018 01:11
Copy link
Contributor

@gauntface gauntface left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from me too and thank you for the discussion in the original issue to claim this work before getting started 🥇

@gmlewis
Copy link
Collaborator

gmlewis commented Oct 30, 2018

Thank you, @gauntface.
Merging.

@gmlewis gmlewis merged commit 01a88ae into google:master Oct 30, 2018
@unblee unblee deleted the support-expand-deployment-api branch October 31, 2018 01:08
@unblee
Copy link
Contributor Author

unblee commented Oct 31, 2018

Thank you, @urohit011 @gmlewis @gauntface 😄

n1lesh pushed a commit to n1lesh/go-github that referenced this pull request Oct 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes Indication that the PR author has signed a Google Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants