Update and remove OAuth endpoints#1461
Conversation
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
Codecov Report
@@ Coverage Diff @@
## master #1461 +/- ##
==========================================
+ Coverage 67.72% 68.01% +0.29%
==========================================
Files 94 94
Lines 8471 8389 -82
==========================================
- Hits 5737 5706 -31
+ Misses 1855 1821 -34
+ Partials 879 862 -17
Continue to review full report at Codecov.
|
|
@googlebot cla signed |
|
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
gmlewis
left a comment
There was a problem hiding this comment.
Thank you, @sh3nan1gans!
Apart from the missing custom media headers in the endpoints and the tests, this LGTM.
After these are added, we should be ready for a second review and LGTM before merging.
|
Thanks for the quick turnaround @gmlewis ! I've added the custom media headers for the 4 endpoints you pointed (thanks for catching that by the way) |
gmlewis
left a comment
There was a problem hiding this comment.
Thank you, @sh3nan1gans!
LGTM.
Awaiting second LGTM before merging.
|
LGTM, fwiw |
|
Thank you, @nightlark. |
Updates based on https://developer.github.com/changes/2019-11-05-deprecated-passwords-and-authorizations-api/#authenticating-using-query-parameters
Fixes #1331.