Skip to content

Update and remove OAuth endpoints#1461

Merged
gmlewis merged 4 commits into
google:masterfrom
clarkbynum:fixDeprecatedOAuthEndpoints
Mar 17, 2020
Merged

Update and remove OAuth endpoints#1461
gmlewis merged 4 commits into
google:masterfrom
clarkbynum:fixDeprecatedOAuthEndpoints

Conversation

@clarkbynum
Copy link
Copy Markdown

@clarkbynum clarkbynum commented Mar 16, 2020

@googlebot
Copy link
Copy Markdown

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 16, 2020

Codecov Report

Merging #1461 into master will increase coverage by 0.29%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1461      +/-   ##
==========================================
+ Coverage   67.72%   68.01%   +0.29%     
==========================================
  Files          94       94              
  Lines        8471     8389      -82     
==========================================
- Hits         5737     5706      -31     
+ Misses       1855     1821      -34     
+ Partials      879      862      -17
Impacted Files Coverage Δ
github/github.go 89.77% <ø> (ø) ⬆️
github/authorizations.go 71.57% <100%> (+15.64%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e0f6eb...be9a16f. Read the comment docs.

@clarkbynum clarkbynum changed the title Update and remove OAuth endpoints to match https://developer.github.com/changes/2019-11-05-deprecated-passwords-and-authorizations-api/#authenticating-using-query-parameters Update and remove OAuth endpoints Mar 16, 2020
@clarkbynum
Copy link
Copy Markdown
Author

@googlebot cla signed

@googlebot
Copy link
Copy Markdown

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes Indication that the PR author has signed a Google Contributor License Agreement. and removed cla: no labels Mar 16, 2020
Copy link
Copy Markdown
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @sh3nan1gans!
Apart from the missing custom media headers in the endpoints and the tests, this LGTM.

After these are added, we should be ready for a second review and LGTM before merging.

Comment thread github/authorizations.go
Comment thread github/authorizations.go
Comment thread github/authorizations.go
Comment thread github/authorizations.go
@clarkbynum
Copy link
Copy Markdown
Author

Thanks for the quick turnaround @gmlewis ! I've added the custom media headers for the 4 endpoints you pointed (thanks for catching that by the way)
Please let me know if there's anything else that needs to be covered.

Comment thread github/authorizations.go Outdated
Comment thread github/github.go Outdated
Copy link
Copy Markdown
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @sh3nan1gans!
LGTM.

Awaiting second LGTM before merging.

@gmlewis gmlewis requested review from gauntface and wesleimp March 17, 2020 01:53
@nightlark
Copy link
Copy Markdown
Contributor

LGTM, fwiw

@gmlewis
Copy link
Copy Markdown
Collaborator

gmlewis commented Mar 17, 2020

Thank you, @nightlark.
Merging.

@gmlewis gmlewis merged commit 419f07c into google:master Mar 17, 2020
sprsld pushed a commit to sprsld/go-github that referenced this pull request Mar 24, 2020
n1lesh pushed a commit to n1lesh/go-github that referenced this pull request Oct 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes Indication that the PR author has signed a Google Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove deprecated authentication API endpoints and add replacements

4 participants