Escape base and head in repos_commits.go#1774
Merged
gmlewis merged 1 commit intogoogle:masterfrom Jan 11, 2021
Merged
Conversation
google-cla
Bot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #1774 +/- ##
=======================================
Coverage 97.53% 97.53%
=======================================
Files 98 98
Lines 6373 6377 +4
=======================================
+ Hits 6216 6220 +4
Misses 85 85
Partials 72 72
Continue to review full report at Codecov.
|
gmlewis
approved these changes
Jan 10, 2021
Collaborator
gmlewis
left a comment
gmlewis
left a comment
There was a problem hiding this comment.
Very nice, @chughpiyush - thank you.
LGTM.
Awaiting second LGTM before merging.
gmlewis
changed the title
Collaborator
|
Thank you, @wesleimp ! |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #1642 as reported in #1654
I added code to escape
baseandheadpart of the URL inCompareCommitsandCompareCommitsRawmethods.Also did changes in relevant test methods, which are now testing for the following 3 cases:
{base: "b", head: "h"}, {base: "123base", head: "head123"}, {base: "`~!@#$%^&*()_+-=[]\\{}|;':\",./<>?/*-+123base", head: "head123`~!@#$%^&*()_+-=[]\\{}|;':\",./<>?/*-+"},P.S. - Here's the original pull request that had to be reverted.