Skip to content

feat: add Installation field in WorkflowRunEvent#2099

Closed
missedone wants to merge 1 commit into
google:masterfrom
missedone:master
Closed

feat: add Installation field in WorkflowRunEvent#2099
missedone wants to merge 1 commit into
google:masterfrom
missedone:master

Conversation

@missedone
Copy link
Copy Markdown

No description provided.

@google-cla
Copy link
Copy Markdown

google-cla Bot commented Sep 19, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-cla google-cla Bot added the cla: no label Sep 19, 2021
@rr-nick-tan
Copy link
Copy Markdown

hi guys, this PR is just show you the Installation field is missing, pls add it, thx

@gmlewis
Copy link
Copy Markdown
Collaborator

gmlewis commented Sep 19, 2021

@rr-nick-tan - I'm not finding an installation field in the WorkflowRunEvent documentation: https://docs.github.com/en/developers/webhooks-and-events/webhooks/webhook-events-and-payloads#workflow_run

Why do you think that this field is missing?

@gmlewis
Copy link
Copy Markdown
Collaborator

gmlewis commented Sep 19, 2021

@rr-nick-tan - I'm not finding an installation field in the WorkflowRunEvent documentation: https://docs.github.com/en/developers/webhooks-and-events/webhooks/webhook-events-and-payloads#workflow_run

Why do you think that this field is missing?

Oh, I apologize... it should be common to all events. Gotcha. I'll add it. Thank you!

@rr-nick-tan
Copy link
Copy Markdown

rr-nick-tan commented Sep 19, 2021

@gmlewis , yes, 'installation' is part of common fields.

BTW, could you also add field check_suite_id in workflow_run, though I don't see it's mentioned in the official doc , but there was similar discussion here https://githubmemory.com/repo/octokit/webhooks/issues/406

I do see the field in the webhook payload
iShot2021-09-19 13 32 28

thank you very much

@gmlewis
Copy link
Copy Markdown
Collaborator

gmlewis commented Sep 19, 2021

BTW, could you also add field check_suite_id in workflow_run, though I don't see it's mentioned in the official doc , but there was similar discussion here https://githubmemory.com/repo/octokit/webhooks/issues/406

Done. Please see #2101.

@rr-nick-tan
Copy link
Copy Markdown

thx @gmlewis

gmlewis added a commit that referenced this pull request Sep 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants