Skip to content

Conversation

@Hash2049
Copy link
Contributor

No description provided.

@gmlewis
Copy link
Collaborator

gmlewis commented Dec 17, 2024

Sorry I wasn't clear before.

I would like to get a solution that addresses the earlier problems mentioned here:
#2898 (comment)
before deprecating NewClientWithEnvProxy.

@gmlewis gmlewis added NeedsInvestigation DO NOT MERGE Do not merge this PR. labels Dec 17, 2024
@codecov
Copy link

codecov bot commented Dec 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.21%. Comparing base (2b8c7fa) to head (f70b041).
Report is 203 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3393      +/-   ##
==========================================
- Coverage   97.72%   92.21%   -5.51%     
==========================================
  Files         153      173      +20     
  Lines       13390    14770    +1380     
==========================================
+ Hits        13085    13620     +535     
- Misses        215     1060     +845     
  Partials       90       90              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Hash2049 Hash2049 closed this Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants