document 'since' pagination for Users.ListAll #367
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
The actual content in this PR looks good to me, I don't see any issues. LGTM. I do have 2 style comments that I'll leave inline for your discretion. The first one (writing |
github/users.go
Outdated
| // } | ||
| // opts.Since = *users[len(users)-1].ID | ||
| // // Process users... | ||
| // } |
Member
There was a problem hiding this comment.
I would suggest making this Go code gofmted. Right now it uses 1 space indent, followed by 2 spaces. How about this:
(Note that the comment always begins with 2 slashes and a space. The rest is its content. The code section is indented by 1 tab. This is the most idiomatic and consistent way to write Go comments, at least if you're as picky about them as me.)
Fixes google#278. Change-Id: Ia1d0c1f6b395d493714d91e0f6e79dc2506f8fde
gmlewis
added a commit
to gmlewis/go-github
that referenced
this pull request
Jun 16, 2016
See google#367 for discussion. Change-Id: I10e26bddebeea2a1485fc4389caab1ff12421382
gmlewis
added a commit
to gmlewis/go-github
that referenced
this pull request
Jun 16, 2016
See google#367 for discussion. Change-Id: I10e26bddebeea2a1485fc4389caab1ff12421382
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #278.
Change-Id: Ia1d0c1f6b395d493714d91e0f6e79dc2506f8fde