Skip to content

Conversation

@sheeeng
Copy link
Contributor

@sheeeng sheeeng commented Nov 6, 2025

Signed-off-by: Leonard Sheng Sheng Lee <leonard.sheng.sheng.lee@gmail.com>
@gmlewis gmlewis changed the title feat(actions_permissions): sha_pinning_required feat: Add sha_pinning_required to ActionsPermissions structs Nov 6, 2025
@codecov
Copy link

codecov bot commented Nov 6, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.27%. Comparing base (943b801) to head (cb55bd5).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3807   +/-   ##
=======================================
  Coverage   92.27%   92.27%           
=======================================
  Files         192      192           
  Lines       13896    13896           
=======================================
  Hits        12823    12823           
  Misses        884      884           
  Partials      189      189           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sheeeng sheeeng marked this pull request as draft November 6, 2025 15:54
Signed-off-by: Leonard Sheng Sheng Lee <leonard.sheng.sheng.lee@gmail.com>
@sheeeng sheeeng marked this pull request as ready for review November 6, 2025 16:09
@sheeeng sheeeng requested a review from gmlewis November 6, 2025 16:10
Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @sheeeng!
LGTM.
Merging.

@gmlewis gmlewis merged commit 8760289 into google:master Nov 6, 2025
7 checks passed
@sheeeng sheeeng deleted the feat/actions_permissions_sha_pinning_required branch November 6, 2025 16:14
@sheeeng
Copy link
Contributor Author

sheeeng commented Nov 7, 2025

@gmlewis, thanks for the review. Do you have any time estimation for this fix to be included in the next release?

@gmlewis
Copy link
Collaborator

gmlewis commented Nov 7, 2025

@gmlewis, thanks for the review. Do you have any time estimation for this fix to be included in the next release?

Usually we cut a release about once per month (and we just cut one 4 days ago), but if there is a need, we can cut another one sooner.

@sheeeng
Copy link
Contributor Author

sheeeng commented Nov 8, 2025

@gmlewis, thanks for the review. Do you have any time estimation for this fix to be included in the next release?

Usually we cut a release about once per month (and we just cut one 4 days ago), but if there is a need, we can cut another one sooner.

@gmlewis, thanks for the quick response. If there is any possibility to release earlier, it would be much appreciated. 🙇 However, it's not urgent. I am waiting to support this feature in integrations/terraform-provider-github#2870.

@gmlewis
Copy link
Collaborator

gmlewis commented Nov 8, 2025

@gmlewis, thanks for the quick response. If there is any possibility to release earlier, it would be much appreciated. 🙇 However, it's not urgent. I am waiting to support this feature in integrations/terraform-provider-github#2870.

@sheeeng - this has now been released here:
https://github.com/google/go-github/releases/tag/v78.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Supportsha_pinning_required for Actions

2 participants