-
Notifications
You must be signed in to change notification settings - Fork 2.2k
feat: Implement Enterprise SCIM - Update Group & User attributes #3848
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3848 +/- ##
==========================================
+ Coverage 92.45% 92.46% +0.01%
==========================================
Files 199 199
Lines 14218 14240 +22
==========================================
+ Hits 13145 13167 +22
Misses 884 884
Partials 189 189 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
gmlewis
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @elminster-aom!
Just a few minor tweaks, please, then we should be ready for a second LGTM+Approval from any other contributor to this repo before merging.
cc: @stevehipwell - @alexandear - @zyfy29
482768a to
97e0188
Compare
gmlewis
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @elminster-aom and @alexandear!
LGTM.
Merging.
Related with #3813
From REST API endpoints for Enterprise SCIM docs, implements:
Update attributes for a SCIM enterprise group, PATCH /scim/v2/enterprises/{enterprise}/Groups/{scim_group_id}
Update attributes for a SCIM enterprise user, PATCH /scim/v2/enterprises/{enterprise}/Users/{scim_user_id}
Other changes: