Skip to content

Conversation

@elminster-aom
Copy link
Contributor

@elminster-aom elminster-aom commented Dec 1, 2025

Related with #3813

From REST API endpoints for Enterprise SCIM docs, implements:

Other changes:

  • Minor improvements for previous SCIM enterprise unit tests code.

@codecov
Copy link

codecov bot commented Dec 1, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.46%. Comparing base (b480d82) to head (e2c8914).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3848      +/-   ##
==========================================
+ Coverage   92.45%   92.46%   +0.01%     
==========================================
  Files         199      199              
  Lines       14218    14240      +22     
==========================================
+ Hits        13145    13167      +22     
  Misses        884      884              
  Partials      189      189              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@elminster-aom elminster-aom marked this pull request as ready for review December 1, 2025 15:44
@gmlewis gmlewis added the NeedsReview PR is awaiting a review before merging. label Dec 1, 2025
Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @elminster-aom!
Just a few minor tweaks, please, then we should be ready for a second LGTM+Approval from any other contributor to this repo before merging.

cc: @stevehipwell - @alexandear - @zyfy29

@elminster-aom elminster-aom changed the title Implement Enterprise SCIM - UpdateAttributeSCIMGroup & UpdateAttributeSCIMUser Implement Enterprise SCIM - Update Group & User attributes Dec 2, 2025
@gmlewis gmlewis removed the NeedsReview PR is awaiting a review before merging. label Dec 2, 2025
Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @elminster-aom and @alexandear!
LGTM.
Merging.

@gmlewis gmlewis changed the title Implement Enterprise SCIM - Update Group & User attributes feat: Implement Enterprise SCIM - Update Group & User attributes Dec 3, 2025
@gmlewis gmlewis merged commit e279f70 into google:master Dec 3, 2025
7 checks passed
@elminster-aom elminster-aom deleted the patchSCIMUsers branch December 3, 2025 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants