-
Notifications
You must be signed in to change notification settings - Fork 2.2k
feat: Implement Enterprise SCIM - Delete Groups or Users #3856
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
30c2495 to
41e5f3e
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3856 +/- ##
=======================================
Coverage 92.38% 92.39%
=======================================
Files 200 200
Lines 14360 14372 +12
=======================================
+ Hits 13267 13279 +12
Misses 894 894
Partials 199 199 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
gmlewis
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @elminster-aom!
LGTM.
Awaiting second LGTM+Approval from any other contributor to this repo before merging.
cc: @stevehipwell - @alexandear - @zyfy29
|
@gmlewis I pushed a last minute commit with enhanced documentation for existing methods |
stevehipwell
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
Thank you, @stevehipwell! |
* forkstream/master: chore!: Remove `PullRequestRuleParameters.AutomaticCopilotCodeReviewEnabled` field (google#3866) feat: Add support for `copilot_code_review` rule type (google#3857) feat: Implement Enterprise SCIM - Delete Groups or Users (google#3856) feat: Add `advanced_search` parameter to `SearchOptions` (google#3868) fix!: Change Org usage report `Quantity` to `float64` (google#3862) build(deps): Bump actions/checkout from 6.0.0 to 6.0.1 in the actions group (google#3863) build(deps): Bump golang.org/x/sync from 0.18.0 to 0.19.0 in /tools (google#3864) build(deps): Bump golang.org/x/term from 0.37.0 to 0.38.0 in /example (google#3865) feat: Implement Enterprise SCIM - Set Groups or Users (google#3858) feat: Add support for Enterprise Team APIs (google#3861) Bump go-github from v79 to v80 in /scrape (google#3855) Bump version of go-github to v80.0.0 (google#3854) feat: Add repository target to ruleset (google#3850)
Related with #3813
From REST API endpoints for Enterprise SCIM docs, implements:
Delete a SCIM group from an enterprise, DELETE /scim/v2/enterprises/{enterprise}/Groups/{scim_group_id}
Delete a SCIM user from an enterprise, DELETE /scim/v2/enterprises/{enterprise}/Users/{scim_user_id}