Skip to content

Conversation

@elminster-aom
Copy link
Contributor

Related with #3813

From REST API endpoints for Enterprise SCIM docs, implements:

@codecov
Copy link

codecov bot commented Dec 4, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.39%. Comparing base (bd1caa0) to head (ad562be).
⚠️ Report is 7 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3856   +/-   ##
=======================================
  Coverage   92.38%   92.39%           
=======================================
  Files         200      200           
  Lines       14360    14372   +12     
=======================================
+ Hits        13267    13279   +12     
  Misses        894      894           
  Partials      199      199           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @elminster-aom!
LGTM.
Awaiting second LGTM+Approval from any other contributor to this repo before merging.

cc: @stevehipwell - @alexandear - @zyfy29

@gmlewis gmlewis added the NeedsReview PR is awaiting a review before merging. label Dec 4, 2025
@elminster-aom
Copy link
Contributor Author

@gmlewis I pushed a last minute commit with enhanced documentation for existing methods

@gmlewis gmlewis changed the title Implement Enterprise SCIM - Delete Groups or Users feat: Implement Enterprise SCIM - Delete Groups or Users Dec 8, 2025
Copy link
Contributor

@stevehipwell stevehipwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gmlewis gmlewis removed the NeedsReview PR is awaiting a review before merging. label Dec 9, 2025
@gmlewis
Copy link
Collaborator

gmlewis commented Dec 9, 2025

Thank you, @stevehipwell!
Merging.

@gmlewis gmlewis merged commit e716505 into google:master Dec 9, 2025
7 checks passed
elminster-aom added a commit to elminster-aom/go-github that referenced this pull request Dec 10, 2025
* forkstream/master:
  chore!: Remove `PullRequestRuleParameters.AutomaticCopilotCodeReviewEnabled` field (google#3866)
  feat: Add support for `copilot_code_review` rule type (google#3857)
  feat: Implement Enterprise SCIM - Delete Groups or Users (google#3856)
  feat: Add `advanced_search` parameter to `SearchOptions` (google#3868)
  fix!: Change Org usage report `Quantity` to `float64` (google#3862)
  build(deps): Bump actions/checkout from 6.0.0 to 6.0.1 in the actions group (google#3863)
  build(deps): Bump golang.org/x/sync from 0.18.0 to 0.19.0 in /tools (google#3864)
  build(deps): Bump golang.org/x/term from 0.37.0 to 0.38.0 in /example (google#3865)
  feat: Implement Enterprise SCIM - Set Groups or Users (google#3858)
  feat: Add support for Enterprise Team APIs (google#3861)
  Bump go-github from v79 to v80 in /scrape (google#3855)
  Bump version of go-github to v80.0.0 (google#3854)
  feat: Add repository target to ruleset (google#3850)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants