Skip to content

Conversation

@stevehipwell
Copy link
Contributor

Fixes #3926

Signed-off-by: Steve Hipwell <steve.hipwell@gmail.com>
@gmlewis
Copy link
Collaborator

gmlewis commented Jan 20, 2026

cc: @tstollin

@gmlewis gmlewis added the NeedsReview PR is awaiting a review before merging. label Jan 20, 2026
@codecov
Copy link

codecov bot commented Jan 20, 2026

Codecov Report

❌ Patch coverage is 84.61538% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 92.44%. Comparing base (44a693d) to head (77c8844).
⚠️ Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
github/orgs_properties.go 84.61% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3928      +/-   ##
==========================================
- Coverage   92.45%   92.44%   -0.01%     
==========================================
  Files         203      203              
  Lines       14949    14960      +11     
==========================================
+ Hits        13821    13830       +9     
- Misses        926      927       +1     
- Partials      202      203       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @stevehipwell!
LGTM.
Awaiting second LGTM+Approval from any other contributor to this repo before merging.

cc: @tstollin

@stevehipwell
Copy link
Contributor Author

This should be ready to be merged.

Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @stevehipwell!
LGTM.
Awaiting second LGTM+Approval from any other contributor to this repo before merging.

@stevehipwell
Copy link
Contributor Author

@alexandear any chance of a review?

@gmlewis
Copy link
Collaborator

gmlewis commented Jan 20, 2026

Thank you, @alexandear!
Merging.

@gmlewis gmlewis removed the NeedsReview PR is awaiting a review before merging. label Jan 20, 2026
@gmlewis gmlewis merged commit 4767af9 into google:master Jan 20, 2026
6 of 8 checks passed
@stevehipwell stevehipwell deleted the fix-property-default-value-strings branch January 20, 2026 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

DefaultValueStrings() returns empty slice for multi_select properties after PR #3906

3 participants