-
Notifications
You must be signed in to change notification settings - Fork 2.2k
fix: Use correct type for custom property default value #3928
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Use correct type for custom property default value #3928
Conversation
Signed-off-by: Steve Hipwell <steve.hipwell@gmail.com>
|
cc: @tstollin |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3928 +/- ##
==========================================
- Coverage 92.45% 92.44% -0.01%
==========================================
Files 203 203
Lines 14949 14960 +11
==========================================
+ Hits 13821 13830 +9
- Misses 926 927 +1
- Partials 202 203 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
gmlewis
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @stevehipwell!
LGTM.
Awaiting second LGTM+Approval from any other contributor to this repo before merging.
cc: @tstollin
|
This should be ready to be merged. |
gmlewis
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @stevehipwell!
LGTM.
Awaiting second LGTM+Approval from any other contributor to this repo before merging.
|
@alexandear any chance of a review? |
|
Thank you, @alexandear! |
Fixes #3926