Skip to content

Sync doc.go and README.md#398

Merged
gmlewis merged 1 commit into
google:masterfrom
gmlewis:docs-sync
Jul 13, 2016
Merged

Sync doc.go and README.md#398
gmlewis merged 1 commit into
google:masterfrom
gmlewis:docs-sync

Conversation

@gmlewis
Copy link
Copy Markdown
Collaborator

@gmlewis gmlewis commented Jul 10, 2016

Fixes #397.

Change-Id: I30ce336e3a36cf5758b9bf52b9dd77f7c1df5f27

@dmitshur
Copy link
Copy Markdown
Member

This is so great! Thanks for doing this @gmlewis!

LGTM.

Comment thread README.md Outdated
application. `go-github` does not handle conditional requests directly, but is
instead designed to work with a caching `http.Transport`. We recommend using
https://github.com/gregjones/httpcache, which can be used in conjunction with
https://github.com/sourcegraph/apiproxy to provide additional flexibility and
Copy link
Copy Markdown
Member

@dmitshur dmitshur Jul 10, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should remove the mention of https://github.com/sourcegraph/apiproxy here.

That repository does not compile successfully for over a year now (see sourcegraph/apiproxy#1).

We've stopped using it and supporting it because it turned out that just using https://github.com/gregjones/httpcache for standards-compliant HTTP caching is good enough in most cases.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How does that last sentence sound now?

Copy link
Copy Markdown
Member

@dmitshur dmitshur Jul 13, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

go-github does not handle conditional requests directly, but is
instead designed to work with a caching http.Transport. We recommend using
https://github.com/gregjones/httpcache, which can be used to provide additional
flexibility and control of caching rules.

I don't think that sounds right. It makes it sound like gregjones/httpcache is used to provide flexibility and control over caching rules, but in fact that package is what provides actual HTTP client-side caching. That phrase previously applied to apicache, which indeed did provide customization over http caching rules.

I think it should be more like this:

go-github does not handle conditional requests directly, but is
instead designed to work with a caching http.Transport. We recommend using
https://github.com/gregjones/httpcache for that.

@gmlewis gmlewis force-pushed the docs-sync branch 2 times, most recently from aa1dffd to 7f243af Compare July 12, 2016 04:08
Fixes google#397.

Change-Id: I30ce336e3a36cf5758b9bf52b9dd77f7c1df5f27
@gmlewis gmlewis merged commit 53a129e into google:master Jul 13, 2016
@gmlewis gmlewis deleted the docs-sync branch July 13, 2016 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants