feat: Add support for team type field#4037
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4037 +/- ##
=======================================
Coverage 94.08% 94.08%
=======================================
Files 207 207
Lines 19217 19217
=======================================
Hits 18081 18081
Misses 938 938
Partials 198 198 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
gmlewis
left a comment
There was a problem hiding this comment.
Thank you, @munlicode!
LGTM.
Awaiting second LGTM+Approval from any other contributor to this repo before merging.
cc: @stevehipwell - @alexandear - @zyfy29 - @Not-Dhananjay-Mishra
|
Since the API also supports "enterprise", would it make sense to add a test case covering that value as well? |
That's optional (since marshaling/unmarshaling is already covered by your previous changes) but feel free to add if you wish for documentation purposes. It's your call. |
|
Thank you, @alexandear! |
Adds
typefield toTeamstruct and updates tests for listing and getting team(s).Note: I updated test to use
assertNoDiff, because it was printing pointers whenTestCopilotService_ListCopilotSeatswas failing. Since it is not really helpful for debugging, I changed it to print difference instead of just comparing if it is equal.Resolves #4033