Skip to content

feat: Add support for team type field#4037

Merged
gmlewis merged 2 commits intogoogle:masterfrom
munlicode:master
Feb 26, 2026
Merged

feat: Add support for team type field#4037
gmlewis merged 2 commits intogoogle:masterfrom
munlicode:master

Conversation

@munlicode
Copy link
Contributor

@munlicode munlicode commented Feb 25, 2026

Adds type field to Team struct and updates tests for listing and getting team(s).

Note: I updated test to use assertNoDiff, because it was printing pointers when TestCopilotService_ListCopilotSeats was failing. Since it is not really helpful for debugging, I changed it to print difference instead of just comparing if it is equal.

Resolves #4033

@gmlewis gmlewis added the NeedsReview PR is awaiting a review before merging. label Feb 26, 2026
@codecov
Copy link

codecov bot commented Feb 26, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.08%. Comparing base (27db7f9) to head (1c36539).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4037   +/-   ##
=======================================
  Coverage   94.08%   94.08%           
=======================================
  Files         207      207           
  Lines       19217    19217           
=======================================
  Hits        18081    18081           
  Misses        938      938           
  Partials      198      198           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @munlicode!
LGTM.
Awaiting second LGTM+Approval from any other contributor to this repo before merging.

cc: @stevehipwell - @alexandear - @zyfy29 - @Not-Dhananjay-Mishra

@maishivamhoo123
Copy link
Contributor

Since the API also supports "enterprise", would it make sense to add a test case covering that value as well?

@gmlewis
Copy link
Collaborator

gmlewis commented Feb 26, 2026

Since the API also supports "enterprise", would it make sense to add a test case covering that value as well?

That's optional (since marshaling/unmarshaling is already covered by your previous changes) but feel free to add if you wish for documentation purposes. It's your call.

@gmlewis
Copy link
Collaborator

gmlewis commented Feb 26, 2026

Thank you, @alexandear!
Merging.

@gmlewis gmlewis merged commit 5f68d54 into google:master Feb 26, 2026
8 checks passed
@gmlewis gmlewis removed the NeedsReview PR is awaiting a review before merging. label Feb 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add support for team type field

4 participants