Add 'munlicode' to REVIEWERS list#4046
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4046 +/- ##
=======================================
Coverage 94.08% 94.08%
=======================================
Files 207 207
Lines 19217 19217
=======================================
Hits 18081 18081
Misses 938 938
Partials 198 198 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Wonderful, @munlicode! Welcome aboard, and thank you so much for volunteering... your help is greatly appreciated!
Great question - first, it is a good idea to read the Markdown (.md) files in this repo and if you have any comments or questions there, then feel free to open issues to discuss them. Second, doing great code reviews comes from experience and dilligence. Lately, three of my current reviewers: @stevehipwell, @alexandear, and @Not-Dhananjay-Mishra have gone the extra mile and taken the time and effort to read and deeply understand the official GitHub v3 API documentation and point out when PRs and code in this repo doesn't fully align with the docs, which I find enormously valuable. As an "old-timer" in this repo and in life, I have seen the GitHub v3 API docs change quite a bit over the years, and I often find myself thinking "I know what it says" and not bothering to go look... and having these helpers who do the due dilligence is incredibly helpful. Sorry, I'm starting to ramble. Let me get back on point... we have some important generators in this repo that attempt to make things easier for maintainers and for developers who wish to contribute PRs... one goal of yours should probably be to:
So I hope you found this useful, and once again, welcome aboard and thenk you for your contributions! |
|
Thank you. I am glad to be of service :D |
I would love to be a reviewer for a few reasons:
go, so I believe reviewing other people's code will be beneficial.AI slopVideo I felt something and thought of adding my username to reviewers list.Thank You, :)
BTH: I would love any advice on how to do better reviews or just how to manage it. Just anything, so I do not miss anything or get confused at some point.