chore: Simplify form value assertions in tests#4048
Merged
gmlewis merged 2 commits intogoogle:masterfrom Feb 27, 2026
Merged
Conversation
alexandear
force-pushed
the
chore/simplify-form-value-asserts
branch
2 times, most recently
from
3f4458e to
02fce8d
Compare
alexandear
force-pushed
the
chore/simplify-form-value-asserts
branch
from
02fce8d to
e6314e2
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4048 +/- ##
=======================================
Coverage 94.08% 94.08%
=======================================
Files 207 207
Lines 19217 19217
=======================================
Hits 18081 18081
Misses 938 938
Partials 198 198 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
gmlewis
reviewed
Feb 27, 2026
Co-authored-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
gmlewis
approved these changes
Feb 27, 2026
Collaborator
gmlewis
left a comment
gmlewis
left a comment
There was a problem hiding this comment.
Thank you, @alexandear!
LGTM.
Merging.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sometimes we have query keys that contain multiple values and need to verify them, for example in
TestOrganizationsService_ListFineGrainedPersonalAccessTokens. So I addedtestFormValuesListinstead of modifyingtestFormValues, since changing it would require many updates.