chore: Remove duplicated formatters

[alexandear]

The formatters gofmt and goimports can be removed because we have more powerful gofumpt and gci.

Updates #4070

[stevehipwell]

@alexandear do we have a need for gci, and if not is there a reason to pick it over goimports? The main reason I ask is because we have a single non-stdlib import in the non-test code and there are only 2 in the main codebase; so it doesn't seem like this is an area we need much power?

[alexandear]

@alexandear do we have a need for gci, and if not is there a reason to pick it over goimports? The main reason I ask is because we have a single non-stdlib import in the non-test code and there are only 2 in the main codebase; so it doesn't seem like this is an area we need much power?

Yes, we do.

goimports allows the following:

import (
	"fmt"

	"net/http"

	"os"

	"github.com/google/go-github/v84/github"

	"google.golang.org/appengine"

	"google.golang.org/appengine/log"
)

gci does not. It formats to:

import (
	"fmt"
	"net/http"
	"os"

	"github.com/google/go-github/v84/github"
	"google.golang.org/appengine"
	"google.golang.org/appengine/log"
)

You can verify this by running:

./bin/custom-gcl fmt --enable=goimports --no-config

./bin/custom-gcl fmt --enable=gci --no-config

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.67%. Comparing base (fca7973) to head (a96259c).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #4094   +/-   ##
=======================================
  Coverage   93.67%   93.67%           
=======================================
  Files         211      211           
  Lines       19478    19478           
=======================================
  Hits        18246    18246           
  Misses       1034     1034           
  Partials      198      198           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[stevehipwell]

@alexandear fair enough, I was only looking at the core codebase.

[stevehipwell]

LGTM

[gmlewis]

Thank you, @alexandear and @stevehipwell!
LGTM.
Merging.