Skip to content

chore: Cache custom golangci-lint binaries in GHA workflow#4116

Merged
gmlewis merged 1 commit intogoogle:masterfrom
alexandear-org:chore/cache-custom-gcl
Mar 19, 2026
Merged

chore: Cache custom golangci-lint binaries in GHA workflow#4116
gmlewis merged 1 commit intogoogle:masterfrom
alexandear-org:chore/cache-custom-gcl

Conversation

@alexandear
Copy link
Contributor

@alexandear alexandear commented Mar 19, 2026

This speeds up the linter job from 3m30s to 2m30s in GitHub Actions when the cache hits.

Updates #4070

Changes:

  • Cache golangci-lint and custom-gcl in GitHub Actions.
  • Rename extraneous-new to extraneousnew for consistency with other custom linters.
  • Derive the golangci-lint version in setup-custom-gcl.sh from .custom-gcl.yml. .custom-gcl.yml is a single source of truth for the golangci-lint version.

Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm very sad that you are removing my beautiful hyphen, but otherwise, LGTM.
Thank you, @alexandear!
Merging.

@gmlewis gmlewis merged commit acab708 into google:master Mar 19, 2026
6 checks passed
@codecov
Copy link

codecov bot commented Mar 19, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.68%. Comparing base (19c1a8a) to head (8ac904a).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4116   +/-   ##
=======================================
  Coverage   93.68%   93.68%           
=======================================
  Files         211      211           
  Lines       19510    19510           
=======================================
  Hits        18278    18278           
  Misses       1034     1034           
  Partials      198      198           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants