Skip to content

Conversation

@mlbright
Copy link
Contributor

role filter 'member' means return only users that are not owners

role filter 'member' means return only users that are not owners
@googlebot googlebot added the cla: yes Indication that the PR author has signed a Google Contributor License Agreement. label Mar 16, 2018
// all - all members of the organization, regardless of role
// admin - organization owners
// member - non-organization members
// member - non-owner members
Copy link
Member

@dmitshur dmitshur Mar 30, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The documentation of role values at https://developer.github.com/v3/orgs/members/#members-list says:

  • member - Non-owner organization members.

Would using that phrasing be better?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect

@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

@googlebot googlebot added cla: no and removed cla: yes Indication that the PR author has signed a Google Contributor License Agreement. labels Aug 10, 2018
@gmlewis gmlewis merged commit 747f93d into google:master Aug 10, 2018
gmlewis pushed a commit to gmlewis/go-github that referenced this pull request Aug 10, 2018
@mlbright mlbright deleted the patch-1 branch August 12, 2018 04:21
n1lesh pushed a commit to n1lesh/go-github that referenced this pull request Oct 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants