Conversation
gmlewis
reviewed
Aug 3, 2018
github/github_test.go
Outdated
| }{ | ||
| Reason: "dmca", | ||
| CreatedAt: &Timestamp{time.Date(2016, 3, 17, 15, 39, 46, 0, time.UTC)}, | ||
| CreatedAt: &Timestamp{time.Date(2016, time.July, 17, 15, 39, 46, 0, time.UTC)}, |
Collaborator
There was a problem hiding this comment.
s/time.July/time.March/
I won't comment on any others... please make sure all the tests pass.
See the CONTRIBUTING.md file in the top of the repo for more details.
Thank you!
Contributor
Author
There was a problem hiding this comment.
Oh, such a silly mistake. Sorry for that :(
Collaborator
|
Very nice. Thank you, @cristaloleg. |
gmlewis
pushed a commit
to gmlewis/go-github
that referenced
this pull request
Aug 10, 2018
n1lesh
pushed a commit
to n1lesh/go-github
that referenced
this pull request
Oct 2, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found by go-critic linter via namedConst check.
From here: #960 (comment)