Skip to content

Conversation

@anthonyjpratti
Copy link
Contributor

This changeset allows embedded fields that are pointers to structs to be encoded in the same manner as embedded fields that are structs.

Looking forward to y'alls feedback!

@google-cla
Copy link

google-cla bot commented Aug 22, 2020

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@anthonyjpratti
Copy link
Contributor Author

@googlebot I signed it!

@willnorris
Copy link
Collaborator

I know this is pretty old, but if this is still something you need, would you mind rebasing onto master and adding a test case that demonstrates what this enables? (The test cases a much more readable compared to when you first opened this, so should be pretty straightforward)

@willnorris
Copy link
Collaborator

never mind... I looked a little more closely, and it makes sense what you're doing here. Merging in now, and adding a simple test.

willnorris added a commit that referenced this pull request Feb 24, 2021
@willnorris
Copy link
Collaborator

merged as e9ef1ee

@willnorris willnorris closed this Feb 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants