Skip to content

Conversation

@edyesed
Copy link
Contributor

@edyesed edyesed commented Feb 2, 2021

Hi,
This library is very useful to me. However, I needed support for Unix epoch-seconds time format with millisecond and nanosecond granularity.

  • I've added support for unix epoch-seconds will millisecond and nanosecond granularity. ( with tests )
  • I added the time.Time type and options to the example struct in README.md as well.

@codecov
Copy link

codecov bot commented Feb 2, 2021

Codecov Report

Merging #44 (388d592) into master (55faf79) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #44   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines          112       116    +4     
=========================================
+ Hits           112       116    +4     
Impacted Files Coverage Δ
query/encode.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 55faf79...386ee79. Read the comment docs.

@willnorris
Copy link
Collaborator

this looks straightforward enough, thanks for the contribution! A few small changes (which I'll just go ahead and make and submit right after this comment)...

  • rename options to "unixmilli" and "unixnano" for naming consistency both with the "unix" option as well as the time.UnixNano() method
  • add documentation for these new options to the package godoc
  • remove the README changes (see Add more examples into README.md #43 for similar discussion), but add a link to the package godocs. I'd ideally prefer to just inline more examples in the godocs, which then keeps all the documentation together. Or possibly just provide a couple of additional advanced examples in the README without changing the simple one that's already there.

@dgsdoug
Copy link

dgsdoug commented Jul 24, 2022

@@ Coverage Diff @@

master #44 +/-

=========================================
Coverage 100.00% 100.00%

Files 1 1
Lines 112 116 +4

  • Hits 112 116 +4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants