autoload.php generates library conflicts in CMSs#447
Closed
deconf wants to merge 1 commit intogoogleapis:masterfrom
deconf:patch-1
Closed
autoload.php generates library conflicts in CMSs#447deconf wants to merge 1 commit intogoogleapis:masterfrom deconf:patch-1
deconf wants to merge 1 commit intogoogleapis:masterfrom
deconf:patch-1
Conversation
CMS extensions and plugin developers should customize autoload.php to avoid redeclare fatal errors
Contributor
|
Thanks! I'm not sure that renaming the function is super worthwhile though - perhaps its easier to add a note to the README with your recommendation? |
Contributor
Author
|
We could also check the function name, and if it wasn't customized we could throw an exception. But that may be a drawback for those using the library outside a CMS. A recommendation in the README it's a good idea. |
Contributor
|
Added a note to the README, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CMS extension and/or plugin developers should customize autoload.php to avoid "redeclare fatal errors"