Fix VerifyException in MarkdownPositions when formatting ordered list items with right parenthesis or plus bullet markers.#1406
Merged
Conversation
copybara-service
Bot
force-pushed
the
test_943593479
branch
from
5501d27 to
5f32e4a
Compare
…list items with right parenthesis or plus bullet markers. Update `LIST_ITEM_START_PATTERN` from `(?:\s*)((-|\*|[0-9]+\.)\s)` to `(?:\s*)(([-+*]|[0-9]+[.)])\s)`. This allows `TokenVisitor.visitListItem` to correctly recognize ordered list markers that use a right parenthesis (`)`) as permitted by Section 5.2 of the CommonMark spec (e.g., `1) foo`), as well as bullet lists using plus (`+ foo`). PiperOrigin-RevId: 943602624
copybara-service
Bot
force-pushed
the
test_943593479
branch
from
5f32e4a to
ff77a3c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix
VerifyExceptioninMarkdownPositionswhen formatting ordered list items with right parenthesis or plus bullet markers.Update
LIST_ITEM_START_PATTERNfrom(?:\s*)((-|\*|[0-9]+\.)\s)to(?:\s*)(([-+*]|[0-9]+[.)])\s). This allowsTokenVisitor.visitListItemto correctly recognize ordered list markers that use a right parenthesis ()) as permitted by Section 5.2 of the CommonMark spec (e.g.,1) foo), as well as bullet lists using plus (+ foo).