This repository was archived by the owner on Jan 10, 2023. It is now read-only.
Add support for a wider variety of numeric types#43
Merged
mishas merged 4 commits intogoogle:masterfrom Oct 14, 2021
Merged
Conversation
This will allow numpy's numeric values to pass the coercion check.
Contributor
|
Hey @perimosocordiae , Thanks for doing this! Can you please make sure that tests are passing both on python2 and python3? Thanks. |
Contributor
Author
|
Ah, my bad. I didn't realize that |
Contributor
Author
|
Friendly ping, @mishas :-) |
Contributor
|
@perimosocordiae , Thanks for the fix, and sorry for taking way too long to get back to it. I'll work on creating a release (v1.10) now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes gh-20, as well as adding support for numpy types and more.