matcher: improve the documentation for Matcher::describe.#809
Merged
Conversation
copybara-service
Bot
force-pushed
the
test_919349747
branch
5 times, most recently
from
abd544b to
0149eeb
Compare
I found the existing documentation a little confusing. It used the word "result" to refer to something that is only a polarity, not an actual result of the matcher, and lacked an example for the negative sense of the matcher. I've corrected both here, putting this in a form that would have been clearer to me as a user. PiperOrigin-RevId: 919484474
copybara-service
Bot
force-pushed
the
test_919349747
branch
from
0149eeb to
6b1a9c0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
matcher: improve the documentation forMatcher::describe.I found the existing documentation a little confusing. It used the word "result"
to refer to something that is only a polarity, not an actual result of the
matcher, and lacked an example for the negative sense of the matcher. I've
corrected both here, putting this in a form that would have been clearer to me
as a user.