Dead condition in AssembleWithContext

[schmilmo]

IMHO

The condition else if a.start is never reached in the code below because if t.SYN is always true when a.start is true

	if half.nextSeq == invalidSequence {
		if t.SYN {
			if *debugLog {
				log.Printf("%v saw first SYN packet, returning immediately, seq=%v", key, seq)
			}
			seq = seq.Add(1)
			half.nextSeq = seq
			action.queue = false
		} else if a.start {
			if *debugLog {
				log.Printf("%v start forced", key)
			}
			half.nextSeq = seq
			action.queue = false
		} else {
			if *debugLog {
				log.Printf("%v waiting for start, storing into connection", key)
			}
		}
	}

gopacket/reassembly/tcpassembly.go

Line 700 in bf568f6

} else if a.start {

Samuel