Make implementation for ICMPv4 as similar as possible to ICMPv6#134
Merged
gconnell merged 8 commits intogoogle:masterfrom Jan 4, 2016
darxriggs:icmp4-refactoring
Merged
Make implementation for ICMPv4 as similar as possible to ICMPv6#134gconnell merged 8 commits intogoogle:masterfrom darxriggs:icmp4-refactoring
gconnell merged 8 commits intogoogle:masterfrom
darxriggs:icmp4-refactoring
Conversation
* to be in line with layers/icmp6.go
* introducing constants for ICMPv4 codes (for types constants already exist)
* reduce code duplication by using a base layer method
* inlining error variable & adapting message
Contributor
|
Thanks for great work on this! |
gconnell
added a commit
that referenced
this pull request
Jan 4, 2016
Make implementation for ICMPv4 as similar as possible to ICMPv6
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.