New protocol crackers

[traetox]

We implemented a Modbus, a good chunk of Ethernet/IP (ENIP), and some Common Industrial Protocol (CIP). The Modbus implementation doesn't have definitions for the specific request/response structures in the modbus payload due to the protocol assuming you know how to apply each structure based on tcp Src Port, but it gets you along way towards a modbus cracker.

ENIP is a GIANT protocol, and CIP is even worse. These are good first steps that implement many of the base layers.

[notti]

Did all authors sign the CLA?

[traetox]

As far as I can tell. Yes.

…

On Fri, Dec 21, 2018 at 12:33 PM Gernot Vormayr ***@***.***> wrote: Did all authors sign the CLA? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#408 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABQ9OIk-RgZgJObp6rRT6q6HXX_aJh1Oks5u7TeDgaJpZM4RsIY0> .

-- :ZZ

[notti]

Not sure if I can do this and if this works:
@googlebot rescan

[notti]

@gconnell I think we need your help.

[gconnell]

Bad googlebot, no cookie.

I'm going to try saying "I signed it". If that doesn't work, cann you try doing that as well? Hopefully one of those will hit the correct googlebot button.

[gconnell]

I signed it.

[traetox]

i signed it.

…

On Wed, Jan 2, 2019 at 9:25 AM Graeme Connell ***@***.***> wrote: I signed it. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#408 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABQ9OJIgwiLwWl-chPqq5LfBbY5_vWaiks5u_N12gaJpZM4RsIY0> .

-- :ZZ

[gconnell]

It looks like there's some commits from kristopher.watts@sinkholesoftware.com (https://github.com/google/gopacket/commit/6951f53738eaf788b2bdd472bc92183df0bc9bfc.patch) which we don't have a CLA for. john.floren@gravwell.io, your CLA checks out fine.

[traetox]

ok, trying to figure out how to resign the CLA.

…

On Wed, Jan 2, 2019 at 9:30 AM Graeme Connell ***@***.***> wrote: It looks like there's some commits from ***@***.*** ( https://github.com/google/gopacket/commit/6951f53738eaf788b2bdd472bc92183df0bc9bfc.patch) which we don't have a CLA for. ***@***.***, your CLA checks out fine. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#408 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABQ9OF13cJEnpEHt32xBQqYGOb7NF3M2ks5u_N6ggaJpZM4RsIY0> .

-- :ZZ

[traetox]

Thats an old email address and pushed into the commit by mistake. Can we do a rewrite to traetox@gmail.com or will that just make the googlebot angry? Kris

…

On Wed, Jan 2, 2019 at 9:31 AM K. Watts ***@***.***> wrote: ok, trying to figure out how to resign the CLA. On Wed, Jan 2, 2019 at 9:30 AM Graeme Connell ***@***.***> wrote: > It looks like there's some commits from > ***@***.*** ( > https://github.com/google/gopacket/commit/6951f53738eaf788b2bdd472bc92183df0bc9bfc.patch) > which we don't have a CLA for. ***@***.***, your CLA checks > out fine. > > — > You are receiving this because you authored the thread. > Reply to this email directly, view it on GitHub > <#408 (comment)>, or mute > the thread > <https://github.com/notifications/unsubscribe-auth/ABQ9OF13cJEnpEHt32xBQqYGOb7NF3M2ks5u_N6ggaJpZM4RsIY0> > . > -- :ZZ

-- :ZZ

[gconnell]

No worries, Googlebot should be fine with the change.

I believe the best way is to use 'git amend' to change the author locally, then force push the commits up to your pull request repo. That should cause all the right stuff to happen :)

[traetox]

on it

…

On Wed, Jan 2, 2019 at 9:41 AM Graeme Connell ***@***.***> wrote: No worries, Googlebot should be fine with the change. I believe the best way is to use 'git amend' to change the author locally, then force push the commits up to your pull request repo. That should cause all the right stuff to happen :) — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#408 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABQ9OLPW3YQiiGTmFE68BsierPrsW-o_ks5u_OE-gaJpZM4RsIY0> .

-- :ZZ

[googlebot]

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

[traetox]

i signed it.

…

On Wed, Jan 2, 2019 at 10:20 AM googlebot ***@***.***> wrote: So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request. *Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.* — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#408 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABQ9ONHabP1C8VSa0FMdCiPRMm8bfYp4ks5u_OptgaJpZM4RsIY0> .

-- :ZZ