icmp serialize: adding payload serialization.#754
Open
cjacobs96 wants to merge 1 commit intogoogle:masterfrom
Open
icmp serialize: adding payload serialization.#754cjacobs96 wants to merge 1 commit intogoogle:masterfrom
cjacobs96 wants to merge 1 commit intogoogle:masterfrom
Conversation
Collaborator
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
Author
|
@googlebot I signed it! |
Collaborator
|
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
RepComm
added a commit
to RepComm/gopacket
that referenced
this pull request
Aug 4, 2024
… allocation and copy during serialization by https://github.com/cjacobs96, see PR: google/gopacket#754
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When serializing an ICMP layer the current function allocates 8 bytes of space which only included the id, seq, and type code.
Rather I think it should reserve what it needs to by adding the required 8 bytes and the length of the payload. Then add the payload to the byte array.
I am fairly new to Go so the submitted solution may not be as clean as it could be.
If the payload is not correctly serialized many types of ICMP messages can be dropped or not properly responded to.
If my proposed solution goes against the structure of the library please let me know and I will edit accordingly.