Skip to content

icmp serialize: adding payload serialization.#754

Open
cjacobs96 wants to merge 1 commit intogoogle:masterfrom
cjacobs96:new_branch
Open

icmp serialize: adding payload serialization.#754
cjacobs96 wants to merge 1 commit intogoogle:masterfrom
cjacobs96:new_branch

Conversation

@cjacobs96
Copy link

When serializing an ICMP layer the current function allocates 8 bytes of space which only included the id, seq, and type code.
Rather I think it should reserve what it needs to by adding the required 8 bytes and the length of the payload. Then add the payload to the byte array.

I am fairly new to Go so the submitted solution may not be as clean as it could be.
If the payload is not correctly serialized many types of ICMP messages can be dropped or not properly responded to.
If my proposed solution goes against the structure of the library please let me know and I will edit accordingly.

@googlebot
Copy link
Collaborator

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@cjacobs96
Copy link
Author

@googlebot I signed it!

@googlebot
Copy link
Collaborator

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants