Skip to content

Add missing EAPOLTypes to EAPOLTypeMetadata#781

Open
pyther wants to merge 1 commit intogoogle:masterfrom
pyther:eapoltypes
Open

Add missing EAPOLTypes to EAPOLTypeMetadata#781
pyther wants to merge 1 commit intogoogle:masterfrom
pyther:eapoltypes

Conversation

@pyther
Copy link

@pyther pyther commented May 2, 2020

EAPOLTypes 1, 2, and 4 return UnknownEAPOLType instead of EAPOLStart, EAPOLLogOff, and EAPOLASFAlert.

I'm not sure if this is the correct way to fix this. The comment under initActualTypeData() in enums.go implies that these should get out generated by gen2.go. I spent some time seeing if I could follow the logic, but being new to Go, I was unable to find any issues with the generation.

Before Patch

88:71:b1:22:a1:e1: UnknownEAPOLType v2, len 0
88:71:b1:22:a1:e1: UnknownEAPOLType v2, len 0
88:71:b1:22:a1:e1: UnknownEAPOLType v2, len 0
00:90:d0:63:ff:01: EAP v1, len 4
00:90:d0:63:ff:01: EAP v1, len 15

After Patch

88:71:b1:22:a1:e1: EAPOLLogOff v2, len 0
88:71:b1:22:a1:e1: EAPOLStart v2, len 0
88:71:b1:22:a1:e1: EAPOLStart v2, len 0
00:90:d0:63:ff:01: EAP v1, len 4
00:90:d0:63:ff:01: EAP v1, len 15

Code: https://gist.github.com/pyther/d8ad389358cffa3ef96b81105fdc6763

@googlebot
Copy link
Collaborator

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@pyther
Copy link
Author

pyther commented May 2, 2020

@googlebot I signed it!

@googlebot
Copy link
Collaborator

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants