BFD: check lengths when decoding auth header#887
Open
matzf wants to merge 1 commit intogoogle:masterfrom
Open
Conversation
Check that the length field of the authentication header matches the data size and check that the slice is long enough before reading the keyed MD5/SHA1 authentication section. Note that the BFD specification (RFC 5880) restricts the valid size of the authentication header "Data" field for all types, but this is (still) not enforced. This fixes a "slice bounds out of range" panic when decoding the Sequence Number field for the keyed MD5/SHA1 authentication section on truncated messages. Found with [go-fuzz](https://github.com/dvyukov/go-fuzz) in [scionproto/scion](https://github.com/scionproto/scion).
Author
|
Friendly ping @gconnell. Let me know if I can help in any way with getting this PR reviewed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Check that the length field of the authentication header matches the
data size and check that the slice is long enough before reading the keyed
MD5/SHA1 authentication section.
Note that the BFD specification (RFC 5880) restricts the valid size of
the authentication header "Data" field for all types, but this is (still) not enforced.
This fixes a "slice bounds out of range" panic when decoding the
Sequence Number field for the keyed MD5/SHA1 authentication section
on truncated messages.
Found with go-fuzz in scionproto/scion.