-
Notifications
You must be signed in to change notification settings - Fork 138
Refactor MOG providers to use dependency injection #3405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3405 +/- ##
============================================
+ Coverage 69.17% 69.26% +0.08%
- Complexity 1587 1589 +2
============================================
Files 316 317 +1
Lines 8499 8491 -8
Branches 939 938 -1
============================================
+ Hits 5879 5881 +2
+ Misses 2048 2038 -10
Partials 572 572
🚀 New features to boost your workflow:
|
app/src/main/java/org/groundplatform/android/ui/map/gms/mog/MogClient.kt
Show resolved
Hide resolved
...main/java/org/groundplatform/android/ui/offlineareas/selector/OfflineAreaSelectorFragment.kt
Outdated
Show resolved
Hide resolved
app/src/test/java/org/groundplatform/android/ui/map/gms/mog/MogSourceProviderTest.kt
Outdated
Show resolved
Hide resolved
andreia-ferreira
approved these changes
Dec 15, 2025
Collaborator
andreia-ferreira
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 🚀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims at using dependency injection for providing remote tile providers instead of manually building the classes at multiple locations.
Verified for regressions by running the app locally and testing offline areas
@andreia-ferreira PTAL?