Skip to content

Conversation

@shobhitagarwal1612
Copy link
Member

@shobhitagarwal1612 shobhitagarwal1612 commented Dec 13, 2025

This PR aims at using dependency injection for providing remote tile providers instead of manually building the classes at multiple locations.

Verified for regressions by running the app locally and testing offline areas

@andreia-ferreira PTAL?

@auto-assign auto-assign bot requested a review from scolsen December 13, 2025 09:13
@shobhitagarwal1612 shobhitagarwal1612 requested review from andreia-ferreira and removed request for scolsen December 13, 2025 09:23
@codecov
Copy link

codecov bot commented Dec 13, 2025

Codecov Report

❌ Patch coverage is 76.92308% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 69.26%. Comparing base (c0dce32) to head (166381f).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...groundplatform/android/ui/map/gms/mog/MogClient.kt 0.00% 2 Missing ⚠️
...platform/android/ui/map/gms/mog/MogTileProvider.kt 66.66% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #3405      +/-   ##
============================================
+ Coverage     69.17%   69.26%   +0.08%     
- Complexity     1587     1589       +2     
============================================
  Files           316      317       +1     
  Lines          8499     8491       -8     
  Branches        939      938       -1     
============================================
+ Hits           5879     5881       +2     
+ Misses         2048     2038      -10     
  Partials        572      572              
Files with missing lines Coverage Δ
...ava/org/groundplatform/android/common/Constants.kt 100.00% <ø> (ø)
...groundplatform/android/model/imagery/TileSource.kt 20.00% <100.00%> (ø)
...atform/android/repository/OfflineAreaRepository.kt 41.09% <ø> (-0.80%) ⬇️
...atform/android/ui/map/gms/mog/MogSourceProvider.kt 100.00% <100.00%> (ø)
...lineareas/selector/OfflineAreaSelectorViewModel.kt 27.27% <100.00%> (ø)
...platform/android/ui/map/gms/mog/MogTileProvider.kt 23.07% <66.66%> (+23.07%) ⬆️
...groundplatform/android/ui/map/gms/mog/MogClient.kt 48.78% <0.00%> (+3.83%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@andreia-ferreira andreia-ferreira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 🚀

@shobhitagarwal1612 shobhitagarwal1612 merged commit 8d9861d into master Dec 15, 2025
7 checks passed
@shobhitagarwal1612 shobhitagarwal1612 deleted the refactor-mog-client branch December 15, 2025 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants