Skip to content

Create UI for showing the LOI pdf report#3739

Merged
andreia-ferreira merged 10 commits into
masterfrom
andreia/3715/pdf-report-ui
May 15, 2026
Merged

Create UI for showing the LOI pdf report#3739
andreia-ferreira merged 10 commits into
masterfrom
andreia/3715/pdf-report-ui

Conversation

@andreia-ferreira
Copy link
Copy Markdown
Collaborator

@andreia-ferreira andreia-ferreira commented May 14, 2026

Towards #3715

This PR adds a new composable SubmissionPdfItem according to the designs. The LoiReport class was also expanded to include the needed information to be displayed by the new composable.

SubmissionPdfItem was added to the :core:ui module, so some adjustments were made to ensure KMP compatibility:

  • created multiplatform string resources in :core:ui
  • refactored the share button to its own multiplatform composable:
    • Its drawable resource had to be added since we can't access icons in androidx.compose.material.icons.Icons in compose multiplatform without adding an additional library
    • The string was also moved to the KMP module and its usages updated accordingly

There are no functionality changes, so it's not possible to see the new UI in the app yet, only in the previews:
Screenshot From 2026-05-14 17-58-09

@shobhitagarwal1612 PTAL?

@auto-assign auto-assign Bot requested a review from gino-m May 14, 2026 17:09
@codecov
Copy link
Copy Markdown

codecov Bot commented May 14, 2026

Codecov Report

❌ Patch coverage is 75.80645% with 15 lines in your changes missing coverage. Please review.
✅ Project coverage is 67.99%. Comparing base (d7dfefc) to head (72ec2e6).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
.../ui/datacollection/DataCollectionScreenPreviews.kt 0.00% 7 Missing ⚠️
...id/ui/home/mapcontainer/jobs/ShareLocationModal.kt 62.50% 6 Missing ⚠️
...datacollection/DataSubmissionConfirmationScreen.kt 88.88% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #3739      +/-   ##
============================================
- Coverage     68.00%   67.99%   -0.01%     
- Complexity     1613     1622       +9     
============================================
  Files           370      370              
  Lines          9563     9609      +46     
  Branches       1248     1251       +3     
============================================
+ Hits           6503     6534      +31     
- Misses         2381     2396      +15     
  Partials        679      679              
Files with missing lines Coverage Δ
...m/android/ui/home/mapcontainer/jobs/LoiJobSheet.kt 66.16% <100.00%> (-1.23%) ⬇️
...tform/domain/model/locationofinterest/LoiReport.kt 100.00% <100.00%> (ø)
...undplatform/domain/usecases/GetLoiReportUseCase.kt 90.00% <100.00%> (+2.19%) ⬆️
...datacollection/DataSubmissionConfirmationScreen.kt 91.57% <88.88%> (-1.02%) ⬇️
...id/ui/home/mapcontainer/jobs/ShareLocationModal.kt 64.06% <62.50%> (-0.53%) ⬇️
.../ui/datacollection/DataCollectionScreenPreviews.kt 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@andreia-ferreira andreia-ferreira merged commit 021ec59 into master May 15, 2026
13 checks passed
@andreia-ferreira andreia-ferreira deleted the andreia/3715/pdf-report-ui branch May 15, 2026 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants