-
Notifications
You must be signed in to change notification settings - Fork 102
[FIX]: [Create/Edit Survey] Options styling fix for select one/multiple options. #2419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
[FIX]: [Create/Edit Survey] Options styling fix for select one/multiple options. #2419
Conversation
…s for select one/multiple only when hovered or selected
Summary of ChangesHello @sidd190, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refines the user interface for survey options in the create/edit survey flow. It specifically targets the styling of input fields for 'select one/multiple' options, ensuring that visual cues like underlines are displayed contextually (on hover or focus) rather than persistently. Additionally, it enhances usability by introducing dynamic placeholders for these input fields. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
The pull request successfully addresses the styling issue for survey options, ensuring that underlines are only visible on hover or when an option is selected. The addition of a dynamic placeholder in the input field also enhances user experience. However, there's a maintainability concern regarding the use of ::ng-deep in the CSS.
web/src/app/components/shared/task-editor/task-form/edit-option/edit-option.component.scss
Show resolved
Hide resolved
|
Ohh no, I forgot to pull the last 2-3 commits and a major refactor was merged I think by @gino-m 's PR around related files. Closing this now, will re-open on the updated codebase. 😿 |
|
@gino-m @rfontanarosa, please take a look whenever possible. Thanks. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2419 +/- ##
=======================================
Coverage 59.58% 59.58%
=======================================
Files 111 111
Lines 2769 2769
Branches 405 405
=======================================
Hits 1650 1650
Misses 1061 1061
Partials 58 58 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
In Survey Options, styling fixed to highlight/underline options for select one/multiple only when hovered or selected
Fixes #1655
Before -
Screencast.from.2026-01-28.16-55-51.webm
After -
Screencast.from.2026-01-29.21-27-42.webm