This repository was archived by the owner on Mar 23, 2023. It is now read-only.
Add Travis CI build status to the README.#2
Merged
trotterdylan merged 1 commit intogoogle:masterfrom Jan 4, 2017
ryankennedy:master
Merged
Add Travis CI build status to the README.#2trotterdylan merged 1 commit intogoogle:masterfrom ryankennedy:master
trotterdylan merged 1 commit intogoogle:masterfrom
ryankennedy:master
Conversation
trotterdylan
added a commit
to trotterdylan/grumpy
that referenced
this pull request
Jul 10, 2017
This implements option google#2 in: google#287 Basically, importing of packages corresponding to Python modules now does not happen in the generated code for the module. Instead, these imports only happen in the main Go package. This simplifies grumpc, since it does not need to track imports for the Python modules it imports. That work is now done in grumprun, which determines the transitive dependencies and imports all those packages in the generated main Go file.
trotterdylan
added a commit
to trotterdylan/grumpy
that referenced
this pull request
Jul 10, 2017
This implements option google#2 in: google#287 Basically, importing of packages corresponding to Python modules now does not happen in the generated code for the module. Instead, these imports only happen in the main Go package. This simplifies grumpc, since it does not need to track imports for the Python modules it imports. That work is now done in grumprun, which determines the transitive dependencies and imports all those packages in the generated main Go file.
trotterdylan
added a commit
that referenced
this pull request
Jul 10, 2017
This implements option #2 in: #287 Basically, importing of packages corresponding to Python modules now does not happen in the generated code for the module. Instead, these imports only happen in the main Go package. This simplifies grumpc, since it does not need to track imports for the Python modules it imports. That work is now done in grumprun, which determines the transitive dependencies and imports all those packages in the generated main Go file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.