bug fix for serializing messages with fields of type map #1418
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Marcono1234
reviewed
Jun 17, 2020
Comment on lines
+244
to
+254
| if(fieldPair.getKey().isMapField() && fieldPair.getValue() instanceof Collection){ | ||
| JsonObject mapObject = new JsonObject(); | ||
| @SuppressWarnings("unchecked") | ||
| Collection<MapEntry<Object,Object>> entries = | ||
| (Collection<MapEntry<Object, Object>>) fieldPair.getValue(); | ||
| for(MapEntry<Object,Object> entry : entries){ | ||
| String key = context.serialize(entry.getKey()).getAsString(); | ||
| mapObject.add(key, context.serialize(entry.getValue())); | ||
| } | ||
| ret.add(name, mapObject); | ||
| }else{ |
Contributor
There was a problem hiding this comment.
Suggested change
| if(fieldPair.getKey().isMapField() && fieldPair.getValue() instanceof Collection){ | |
| JsonObject mapObject = new JsonObject(); | |
| @SuppressWarnings("unchecked") | |
| Collection<MapEntry<Object,Object>> entries = | |
| (Collection<MapEntry<Object, Object>>) fieldPair.getValue(); | |
| for(MapEntry<Object,Object> entry : entries){ | |
| String key = context.serialize(entry.getKey()).getAsString(); | |
| mapObject.add(key, context.serialize(entry.getValue())); | |
| } | |
| ret.add(name, mapObject); | |
| }else{ | |
| if (fieldPair.getKey().isMapField() && fieldPair.getValue() instanceof Collection) { | |
| JsonObject mapObject = new JsonObject(); | |
| @SuppressWarnings("unchecked") | |
| Collection<MapEntry<Object, Object>> entries = | |
| (Collection<MapEntry<Object, Object>>) fieldPair.getValue(); | |
| for (MapEntry<Object, Object> entry : entries) { | |
| String key = context.serialize(entry.getKey()).getAsString(); | |
| mapObject.add(key, context.serialize(entry.getValue())); | |
| } | |
| ret.add(name, mapObject); | |
| } else { |
| .create(); | ||
| } | ||
|
|
||
| //TODO |
Contributor
There was a problem hiding this comment.
Do you have a test which shows that this works as expected?
Note that I am not a Maintainer, and it could happen that even if you change this pull request it might not be merged (in the near future).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr addresses #1417
Unit tests still need to be wrapped up
This change is