Clean up interface method declarations by removing redundant public modifiers#2944
Merged
eamonnmcmanus merged 2 commits intogoogle:mainfrom Nov 22, 2025
Merged
Clean up interface method declarations by removing redundant public modifiers#2944eamonnmcmanus merged 2 commits intogoogle:mainfrom
public modifiers#2944eamonnmcmanus merged 2 commits intogoogle:mainfrom
Conversation
Member
|
This makes sense. Google's internal "Java Practices" guide calls for omitting redundant modifiers like these. |
eamonnmcmanus
approved these changes
Nov 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This pull request makes a small stylistic cleanup of nested interface method declarations.
Some methods currently include the
publicmodifier while others rely on Java’s implicit visibility.This inconsistency is purely visual and does not affect functionality.
Removing the redundant modifiers improves readability and enforces a consistent code style.
Description
In Java, interface methods are implicitly
public, so explicitly declaringpublicis unnecessary.This PR removes the redundant
publickeywords from nested interface methods throughout the codebase.
No behavior or public API changes are introduced.
The change is intended solely to make the code easier to read, review, and maintain.
Checklist
This is automatically checked by
mvn verify, but can also be checked on its own usingmvn spotless:check.Style violations can be fixed using
mvn spotless:apply; this can be done in a separate commit to verify that it did not cause undesired changes.mvn clean verify javadoc:jarpasses without errors