Improve JsonArrayAsListTest#testContains#2982
Merged
eamonnmcmanus merged 1 commit intogoogle:mainfrom Feb 16, 2026
Merged
Conversation
Reverts some previous changes to this method which accidentally converted the assertions to `assertThat(...).contains(...)`.
Marcono1234
force-pushed
the
marcono1234/testContains
branch
from
6963b2b to
87934d0
Compare
Member
|
Makes sense. I think in practice |
eamonnmcmanus
approved these changes
Feb 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up for #2981, which removed
assertThat(list).doesNotContain(null)Reverts some previous changes to this method which accidentally converted the assertions to
assertThat(...).contains(...).