Add LegacyProtoTypeAdapterFactory.#3014
Merged
eamonnmcmanus merged 7 commits intomainfrom Apr 17, 2026
Merged
Conversation
This is a migration aid for code that is currently accidentally relying on `ReflectiveTypeAdapterFactory` to serialize and/or deserialize protobuf messages. Such code depends on the internal details of how protobuf messages are represented as Java objects, and can break if those details change. This adapter freezes a particular representation and allows code to become independent of future changes. We do not recommend this for anything other than managing legacy code that may have come to rely on a particular JSON format.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| String fieldName = readFieldName(in); | ||
| Matcher matcher = BIT_FIELD_PATTERN.matcher(fieldName); | ||
| if (matcher.matches()) { | ||
| int shift = Integer.parseInt(matcher.group(1)) * 32; |
This is pretty theoretical, but github-advanced-security flagged it.
cpovirk
approved these changes
Apr 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a migration aid for code that is currently accidentally relying
on
ReflectiveTypeAdapterFactoryto serialize and/or deserializeprotobuf messages. Such code depends on the internal details of how
protobuf messages are represented as Java objects, and can break if
those details change. This adapter freezes a particular representation
and allows code to become independent of future changes.
We do not recommend this for anything other than managing legacy code
that may have come to rely on a particular JSON format.
This code is not currently part of any released artifact.